This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
feat: cache the materialized wantlist #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
approved these changes
Sep 7, 2021
dirkmc
reviewed
Sep 7, 2021
This can become a hot-spot.
Stebalien
force-pushed
the
feat/cache-wantlist
branch
from
3cbe74d
to
a19b05e
Compare
Stebalien
commented
Sep 7, 2021
| // called frequently. | ||
|
|
||
| // Add each regular want-have / want-block to the message. | ||
| if msgSize+(len(peerEntries)*bsmsg.MaxEntrySize) > mq.maxMessageSize { |
There was a problem hiding this comment.
We're now eagerly sorting which could affect performance. However, I believe the real perf issue was that we were repeatedly sorting the same broadcast list over-and-over, which we're now doing at most once per change.
dirkmc
reviewed
Sep 9, 2021
There was a problem hiding this comment.
LGTM but I would love to see a test to make sure the cache-busting and sorting works as expected.
Also I assume there was a performance bottleneck observed in production that motivated this change. I suggest we observe performance in the same situation before merging to make sure this solves the problem.
This test explicitly calls entries to make sure the cache is materialized.
|
Sorting test is go-bitswap/wantlist/wantlist_test.go Line 206 in a19b05e |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
feat: cache the materialized wantlist This commit was moved from ipfs/go-bitswap@d48cbc1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can become a hot-spot.